From 40f78d7c11bb96b7644edbcf8c49cb99be57eae9 Mon Sep 17 00:00:00 2001
From: Jindra Lacko <jindra@jla-data.net>
Date: Thu, 19 Sep 2024 11:21:58 +0200
Subject: [PATCH] cleaner history / s2 artefacts removed

---
 NEWS.md                          |  4 +++
 R/historie.R                     |  2 +-
 data-raw/digest-historie.R       | 50 ++++++++++++++++++++++++++++++++
 tests/testthat/test-1-historie.R |  2 +-
 4 files changed, 56 insertions(+), 2 deletions(-)
 create mode 100644 data-raw/digest-historie.R

diff --git a/NEWS.md b/NEWS.md
index 21670ca..724ad65 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -1,3 +1,7 @@
+## version 1.12.2.99999
+
+ - history objects updated to return cleaner geometry 
+
 ## version 1.12.2 (2024-07-07)
 
  - katastry function added to serve cadastral areas / katastrální území
diff --git a/R/historie.R b/R/historie.R
index c49da1e..f904dc3 100644
--- a/R/historie.R
+++ b/R/historie.R
@@ -62,6 +62,6 @@ historie <- function(era) {
     stop(paste(era, "is not a valid historical era!"))
   }
 
-  result <- .downloader(paste0("history_", era, ".rds"))
+  result <- .downloader(paste0("history_", era, "v2.rds"))
   result
 }
diff --git a/data-raw/digest-historie.R b/data-raw/digest-historie.R
new file mode 100644
index 0000000..61cc901
--- /dev/null
+++ b/data-raw/digest-historie.R
@@ -0,0 +1,50 @@
+library(sf)
+library(arcpullr)
+
+remote_target <- "https://services1.arcgis.com/LPm07959azIAvFRD/ArcGIS/rest/services/urrlab_historicky_gis_cesko/FeatureServer/"
+
+objekty <- list( "3" = "okresy_1921",
+                 "4" = "okresy_1930",
+                 "2" = "okresy_1947",
+                 "6" = "okresy_1950",
+                 "7" = "okresy_1961",
+                 "8" = "okresy_1970",
+                 "9" = "okresy_1980",
+                "10" = "okresy_1991",
+                "11" = "okresy_2001",
+                "12" = "okresy_2011",
+                "13" = "kraje_1950",
+                "14" = "kraje_1961",
+                "15" = "kraje_1970",
+                "16" = "kraje_1980",
+                "17" = "kraje_1991",
+                "18" = "kraje_2001",
+                "19" = "kraje_2011")
+
+
+for (i in seq_along(objekty)) {
+
+  wrk_objekt <- arcpullr::get_spatial_layer(paste0(remote_target, names(objekty)[i]))
+
+  info <- arcpullr::get_layer_info(paste0(remote_target, names(objekty)[i]))
+
+  clean_objekt <- wrk_objekt %>%
+    st_make_valid() %>%
+    st_transform(4326)
+
+  colnames(clean_objekt) <- c(info$fields$alias, "geometry")
+
+  st_geometry(clean_objekt) <- "geometry"
+
+  duplicity <- which(duplicated(colnames(clean_objekt))) # indexy duplictních názvů sloupců
+
+  clean_objekt <- clean_objekt[, -duplicity] # duplicitní sloupce ven!
+
+  if((st_crs(clean_objekt)$input == "EPSG:4326") & all(st_is_valid(clean_objekt))) {
+    saveRDS(clean_objekt, paste0("./data-backup/history_", objekty[i], "v2.rds"))
+  } else {
+    warning(paste(objekty[i], "je nevalidní, ještě jednou a pořádně!!"))
+  }
+
+}
+
diff --git a/tests/testthat/test-1-historie.R b/tests/testthat/test-1-historie.R
index 74758c9..6c13011 100644
--- a/tests/testthat/test-1-historie.R
+++ b/tests/testthat/test-1-historie.R
@@ -67,7 +67,7 @@ test_that("historie platí", {
     expect_true("geometry" %in% colnames(historie(doba)))
 
     # území je pokryté
-    expect_equal(sum(st_area(historie(doba))), st_area(republika("high")), tolerance = 5/100)
+    expect_equal(sum(st_area(historie(doba))), st_area(republika("high")), tolerance = 1/1000)
 
   }