Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration option withPostgresReactiveDriver() seems to be incorrect name #219

Open
apatrida opened this issue Dec 17, 2022 · 1 comment
Open

Configuration option withPostgresReactiveDriver() seems to be incorrect name #219

apatrida opened this issue Dec 17, 2022 · 1 comment
Milestone
7.0.0

Comments

@apatrida
Copy link

The configuration option withPostgresReactiveDriver as used in the quarkus demo is odd because it references io.vertx.mysqlclient as well as io.vertx.pgclient and in the demo is using a MySQL connection.

Is this really withReactiveDriver instead of PostgreSQL specific setting? If so, it should be renamed.
@jklingsporn
Copy link
Owner

The first reactive driver was indeed just written for Postgres-database. The adoption of other vendors happened afterwards. So yes, you are right, the name is no longer fitting.

@jklingsporn jklingsporn added this to the 7.0.0 milestone Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
2 participants
@apatrida @jklingsporn