AbstractVertxDAO.update() ignores optimistic locking

[badgerwithagun]

As detailed here, jooq has inbuilt support for optimistic locking on updates.

However, the implementation of update(P object in AbstractVertxDAO ignores this.

The core logic is covered in org.jooq.impl.UpdatableRecordImpl#storeUpdate0.

[jklingsporn]

Thanks for your hint. vertx-jooq however does not support the record's store methods. In fact you should never use them when using vertx-jooq as well. I should probably overwrite these methods during code generation and let them throw an UnsupportedOperationException.
Reason being is that these methods bypass the QueryExecutors and will always use plain JDBC. There are also no future plans in supporting the Record's CRUD-methods.

[badgerwithagun]

@jklingsporn I'm not suggesting the record's CRUD methods should be working.

I'm suggesting that the AbstractVertxDAO.update() method, which is part of this library, should handle optimistic locking columns in the same way as the record's CRUD methods and the normal j00Q DAOs.

That is, when I call AbstractVertxDAO.update() with a version column on my table, AbstractVertxDAO.update()`should execute, for example:

UPDATE Foo .... WHERE id = :id AND version = :version

Instead of

UPDATE Foo .... WHERE id = :id

It doesn't at the moment, which means the DAO can't be used for tables implementing optimistic locking.

[jklingsporn]

Is that also covered by plain jooq daos? Graham Crockford <[email protected]> schrieb am Mo., 20. Apr. 2020, 15:07:

…

@jklingsporn <https://github.com/jklingsporn> I'm not suggesting the record's CRUD methods should be working. I'm suggesting that the AbstractVertxDAO.update() method, which is part of this library, should handle optimistic locking columns in the same way as the record's CRUD methods and the normal j00Q DAOs. That is, when I call AbstractVertxDAO.update() with a version column on my table, AbstractVertxDAO.update()`should execute, for example: UPDATE Foo .... WHERE id = :id AND version = :version Instead of UPDATE Foo .... WHERE id = :id It doesn't at the moment, which means the DAO can't be used for tables implementing optimistic locking. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#145 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQLZXXA3VCNJXC7JKEC7TLRNRCHNANCNFSM4MLWZENA> .

[badgerwithagun]

Is that also covered by plain jooq daos?

Yes - DAOImpl forwards to the record's CRUD methods!

[jklingsporn]

Damn it :D I will look into it as soon as I find the time. You can also contribute if you want. Graham Crockford <[email protected]> schrieb am Mo., 20. Apr. 2020, 15:24:

…

Is that also covered by plain jooq daos? Yes - DAOImpl forwards to the record's CRUD methods! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#145 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQLZXVMTMIGIBDTXXEIPU3RNREHFANCNFSM4MLWZENA> .

[badgerwithagun]

Will also look into it if I have time! Could you re-open the issue?