Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen sharing with audio doesn't ignore jitsi's output #988

Open
BigBoss1941 opened this issue Nov 3, 2024 · 2 comments
Open

Screen sharing with audio doesn't ignore jitsi's output #988

BigBoss1941 opened this issue Nov 3, 2024 · 2 comments

Comments

@BigBoss1941
Copy link

Description

As title suggest, when ScreenSharing with audio enabled, other participants in the call will hear themselves in the audio, since jitsi fails to isolate it's own output.

Current behavior

Jitsi output is shared with the audio streamed to the ScreenShare

Expected Behavior

Jitsi should not stream other participant's audio stream into its own ScreenShare Audio stream

Possible Solution

No idea.

Steps to reproduce

Get in a call with two participants, both with microphone activated, and enable ScreenSharing with audio.
Once someone talks, there should be an Echo-like audio feedback.

Environment details

  • Windows 10
  • Intel CPU + Nvidia GPU if it matters.
@saghul
Copy link
Member

saghul commented Nov 4, 2024

@jallamsetty1 I think this is also another reason to move to gDM in Electron, IIRC that code path does enable the echo canceller but the gUM path doesn't, and patches to fix that have been rejected.

@jallamsetty1
Copy link
Member

@jallamsetty1 I think this is also another reason to move to gDM in Electron, IIRC that code path does enable the echo canceller but the gUM path doesn't, and patches to fix that have been rejected.

Yes! I will scheduling this work as part of the new LJM APIs for track creation/addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants