Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromium 123 added support for desktop soundsharing on linux! 🚀🚀 #945

Open
fvalasiad opened this issue Feb 17, 2024 · 6 comments · Fixed by #960
Open

Chromium 123 added support for desktop soundsharing on linux! 🚀🚀 #945

fvalasiad opened this issue Feb 17, 2024 · 6 comments · Fixed by #960
Labels
GNU/Linux Issues affecting GNU/Linux

Comments

@fvalasiad
Copy link

Hello!

Finally, this very desirable feature for some of us has been added, as a matter of fact using ChromeDev I tested it and found it to be (mostly) working! Can expect the few issues here and there to be fixed by the time it reaches the stable branch.

I am opening this issue because I am unfamiliar with the development of electron apps or even this particular app, to ask when can we expect this feature to land after it has landed in chromium's stable branch. Will it be as soon as possible or is there anything that has you holding back chromium's version?

Thanks in advance!
F.

Relevant link: https://issues.chromium.org/issues/40155218
Note: You can test it yourself using flathub's ChromeDev

@saghul
Copy link
Member

saghul commented Feb 17, 2024

Once there is an Electron release with that base Chromium we'll get the feature as part of the usual updates we do.

Thanks for sharing!

@csett86
Copy link
Member

csett86 commented Mar 10, 2024

And that would be Electron 30 which will come mid of April with Chromium 124: https://github.com/electron/electron/blob/main/docs/tutorial/electron-timelines.md

@csett86 csett86 added the GNU/Linux Issues affecting GNU/Linux label Mar 10, 2024
@fvalasiad
Copy link
Author

The day has come people, remember to close the issue as completed when you update to electron 30!

csett86 added a commit that referenced this issue May 10, 2024
csett86 added a commit that referenced this issue May 10, 2024
@csett86
Copy link
Member

csett86 commented May 10, 2024

Looking at electron/electron#10515 it seems that some electron bits might also be required to get this to work.

And then its gated to windows on the frontend as well, at the moment: https://github.com/jitsi/jitsi-meet/blob/master/react/features/screen-share/functions.ts#L34

So reopening this issue :)

@csett86 csett86 reopened this May 10, 2024
@fvalasiad
Copy link
Author

Looking at electron/electron#10515 it seems that some electron bits might also be required to get this to work.

And then its gated to windows on the frontend as well, at the moment: https://github.com/jitsi/jitsi-meet/blob/master/react/features/screen-share/functions.ts#L34

So reopening this issue :)

I know for certain that in vanilla chromium/chrome/brave you need to set #pulseaudio-loopback-for-cast and #pulseaudio-loopback-for-screen-share to get it to work, so maybe there are extra steps in achieving this in the electron app too? :D.

@fvalasiad
Copy link
Author

Oh we actually have to wait for electron to support it separately, I see.

Well no big deal, will manage with vanilla chromium till then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GNU/Linux Issues affecting GNU/Linux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants