Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instrument not detected coz method getSoundfontInstrumentName is wrong #127

Open
burmistrov-alexander opened this issue Sep 26, 2024 · 0 comments

Comments

@burmistrov-alexander
Copy link

Hi!

this method doesnt replace round brackets

private getSoundfontInstrumentName(midiName: string): string {
return midiName.toLowerCase().replace(/\s+/g, "_");
}

midiinstruments:
...
[24, "Acoustic Guitar (nylon)"],
[25, "Acoustic Guitar (steel)"],
[26, "Electric Guitar (jazz)"],
[27, "Electric Guitar (clean)"],
[28, "Electric Guitar (muted)"],
...
so, after calling getSoundfontInstrumentName() this names we got "acoustic_guitar_(nylon)" but it should be "acoustic_guitar_nylon", because file musyngkiteInstruments.ts include this name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant