Skip to content
This repository has been archived by the owner on May 25, 2018. It is now read-only.

Rename internal classes so that they're prefixed with Faye #46

Open
ghost opened this issue Jul 3, 2013 · 1 comment
Open

Rename internal classes so that they're prefixed with Faye #46

ghost opened this issue Jul 3, 2013 · 1 comment

Comments

@ghost
Copy link

ghost commented Jul 3, 2013

So, for example, Channel would be renamed to FayeChannel, Message would be renamed to FayeMessage, etc.

This would make it much harder for classes like Channel and Message to collide with user-defined models, and considering how they're mostly used internally, it shouldn't be too much of a problem to rename them.
@jimsynz
Copy link
Owner

jimsynz commented Dec 31, 2014

Sounds great. Feel free to send a PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jimsynz