Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to disable output buffering #57

Closed
2 tasks
jigarius opened this issue Oct 23, 2022 · 1 comment · Fixed by #103
Closed
2 tasks

Add an option to disable output buffering #57

jigarius opened this issue Oct 23, 2022 · 1 comment · Fixed by #103
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed Priority: High
Milestone

Comments

@jigarius
Copy link
Owner

jigarius commented Oct 23, 2022

Motivation

  • Currently, Drall uses amphp/process libraries to execute commands in parallel.
  • This means the output of every command is buffered and then displayed when the command finishes.
  • In some scenarios, say, when running with only 1 worker, the user might be interested in seeing the command output in realtime instead.
    • This also helps in debugging Drall.
  • Maybe we could use a parameter, say, --drall-no-buffer that would force Drall to throw all output to the console instead of collecting it in a variable.

Tasks

  • Upgrade amphp/* libraries to 2.x.
    • The newer version seems easier to use and understand.
  • Create option: --no-buffer, -B.
@jigarius jigarius added the enhancement New feature or request label Oct 23, 2022
@jigarius jigarius added this to the v2.1 milestone Oct 23, 2022
@jigarius jigarius changed the title Disable output buffering when running with 1 worker Add an option to disable output buffering Apr 4, 2023
@jigarius
Copy link
Owner Author

jigarius commented Apr 4, 2023

Instead of duplicating the code execution logic, I was checking if this can be done through the Amphp libraries, however, I think it will take more time and research that I had initially thought. For now, I'll leave this open. Any ideas or help is welcome. I'd prefer to have the commands executed the same way, whether we have 1 or n workers. That will help us avoid having multiple ways for command execution.

@jigarius jigarius added the help wanted Extra attention is needed label Apr 4, 2023
@jigarius jigarius modified the milestones: v2.1, v3.0 May 4, 2023
@jigarius jigarius removed this from the v3.0 milestone May 14, 2023
@jigarius jigarius added this to the v4.0 milestone Dec 27, 2024
@jigarius jigarius self-assigned this Dec 28, 2024
jigarius added a commit that referenced this issue Dec 29, 2024
jigarius added a commit that referenced this issue Dec 29, 2024
@jigarius jigarius linked a pull request Dec 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed Priority: High
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant