Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should grid point randomly sampled or evenly distributed #21

Open
turboxin opened this issue Apr 9, 2020 · 1 comment
Open

Should grid point randomly sampled or evenly distributed #21

turboxin opened this issue Apr 9, 2020 · 1 comment

Comments

@turboxin
Copy link

turboxin commented Apr 9, 2020

Hi @jhultman,thanks for sharing your implementation.

According to the original paper, the grid points are uniformly sampled within a proposal, I think "uniformly" here means evenly distributed in every dimension( from figure4 we can see the red grid points are not randomly sampled), and the name "grid" itself may also claim this point.

I think "uniformly" here is different from "uniform distribution" given by torch.rand

(torch.rand((b, n, m, 3), device=boxes.device) - 0.5)

@jhultman
Copy link
Owner

jhultman commented Apr 9, 2020

Hi @turboxin, yes I think you are right -- I will fix this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants