New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run with set -e (and fix some related problems) #8

Open

vorburger opened this issue Oct 2, 2018 · 1 comment

Contributor

vorburger commented Oct 2, 2018

I just tried this out for the first time, and initially ran ./build with .../netvirt/karaf instead of just .../netvirt.

This caused a lot of errors, but ./build did not stop - perhaps this would be more user friendly if it did?

Just adding a set -e is not sufficient, the scrips(s) would need to have additional checks, e.g. 👍

+ for i in 1 2 3
+ base=./mounts/1
+ sudo mount -t overlay
+ grep -o mounts/1/assembly
+ xargs sudo umount
umount: bad usage
Try 'umount --help' for more information.

@jhershberg could this be a useful enhancement?

The text was updated successfully, but these errors were encountered:

Owner

jhershberg commented Oct 3, 2018

Yeah, I think it would be a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment