You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Javadocs gets an error due to the missing import for a "@link" annotation of the PDGGraphics2D class in FunctionType.java.
Also, Javadocs and its containing Maven target folder is not in the gitignore. I added these lines to my own gitignore:
target/
The POM file appears to have a copy/paste mistake in the "name" field, which is set to "org.jfree.pdf" instead of "JFreePDF".
I tried to do a partial pull for the two issues mentioned at the top (I did not change the POM file so am just commenting my observations here), but was unsuccessful in that endeavor, so I chose to document the relevant changes in this new Issue instead.
After all, I only created my new fork in order to switch the build for Java 1.8 vs. Java 11 (I am still stuck at Java 8 until SpreadsheetView in ControlsFX finally becomes available for Modular Java), and those changes shouldn't be merged into the main branch. So a pull request, event with commentary, seemed inappropriate.
I also added ".DS_Store" to my gitignore file, but there seems to be a recommended best practice of not including these or ".class" files or anything else fairly general and to instead trust that all potential contributors set up a global gitignore on their computer using the recommendations here:
I'm not seeing that as a widely adopted practice, so you may want to add "*.DS_Store" to your gitignore files as those show up for every directory on macOS and are time-consuming to exclude manually from a commit. There's a way to prevent their creation, or to batch-delete them, but it can mess up other applications to do so.
I was going to make the suggestion to add "*.DS_Store" to the Java template in the gitignore project on GitHub:
That's where I saw people's hands slapped with the admonition to use a global gitgnore for one's computer instead.
The text was updated successfully, but these errors were encountered:
mhschmieder
changed the title
Minor Javadoc bugfix for missing import in FunctionType.java (trivial one-line fix)
Minor Javadoc bugfix for missing import in FunctionType.java + POM and gitignore oversights
Jul 24, 2020
mhschmieder
changed the title
Minor Javadoc bugfix for missing import in FunctionType.java + POM and gitignore oversights
Missing import in FunctionType.java for PDFGraphics2D (causes javadocs error), plus minor POM and gitignore oversights
Jul 24, 2020
Javadocs gets an error due to the missing import for a "@link" annotation of the PDGGraphics2D class in FunctionType.java.
Also, Javadocs and its containing Maven target folder is not in the gitignore. I added these lines to my own gitignore:
target/
The POM file appears to have a copy/paste mistake in the "name" field, which is set to "org.jfree.pdf" instead of "JFreePDF".
I tried to do a partial pull for the two issues mentioned at the top (I did not change the POM file so am just commenting my observations here), but was unsuccessful in that endeavor, so I chose to document the relevant changes in this new Issue instead.
After all, I only created my new fork in order to switch the build for Java 1.8 vs. Java 11 (I am still stuck at Java 8 until SpreadsheetView in ControlsFX finally becomes available for Modular Java), and those changes shouldn't be merged into the main branch. So a pull request, event with commentary, seemed inappropriate.
I also added ".DS_Store" to my gitignore file, but there seems to be a recommended best practice of not including these or ".class" files or anything else fairly general and to instead trust that all potential contributors set up a global gitignore on their computer using the recommendations here:
http://egorsmirnov.me/2015/05/04/global-gitignore-file.html
I'm not seeing that as a widely adopted practice, so you may want to add "*.DS_Store" to your gitignore files as those show up for every directory on macOS and are time-consuming to exclude manually from a commit. There's a way to prevent their creation, or to batch-delete them, but it can mess up other applications to do so.
I was going to make the suggestion to add "*.DS_Store" to the Java template in the gitignore project on GitHub:
https://github.com/github/gitignore/blob/master/Global/macOS.gitignore
That's where I saw people's hands slapped with the admonition to use a global gitgnore for one's computer instead.
The text was updated successfully, but these errors were encountered: