New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata Injection issue #16

Open

IchthysMaranatha opened this issue Dec 7, 2022 · 1 comment

IchthysMaranatha commented Dec 7, 2022

Hi, thank you very much for your work.

Metadata Injection doesn't seem to work, should this line have 'INPUT_FIELDS' instead?

Pentaho-Google-Sheet-Plugin/src/main/java/org/pentaho/di/trans/steps/pentahogooglesheets/PentahoGoogleSheetsPluginInputMeta.java

Line 101 in 65bb640

@Injection( name = "sampleFields", group = "INPUT_Fields" )

Author

IchthysMaranatha commented Dec 20, 2022

When the above line is deleted, it works well. Sample fields are anyway not needed for injection, only for interactive 'get fields'
Have put the lines this way after forking and it works
https://github.com/IchthysMaranatha/Pentaho-Google-Sheet-Plugin/blob/1e4617d00df8ae3598e799220887a9813f7ed0eb/src/main/java/org/pentaho/di/trans/steps/pentahogooglesheets/PentahoGoogleSheetsPluginInputMeta.java#L103-L107
Binary plugin here https://github.com/IchthysMaranatha/Pentaho-Google-Sheet-Plugin/blob/master/delivery/PentahoGoogleSheetsPlugin-5-distribution.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment