Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted and Inserted indexes not being tested #52

Open
AleLudovici opened this issue Apr 6, 2017 · 1 comment
Open

Deleted and Inserted indexes not being tested #52

AleLudovici opened this issue Apr 6, 2017 · 1 comment

Comments

@AleLudovici
Copy link

Hi,

I've noticed that the unit tests are not asserting correctly that insertion and deletions happens at the expected indexes. Expectations were only being fulfilled but not asserted.
I've also took the chance to refactor the Unit test to improve the readability and to separate them by test domain.
I've already open a PR #51 with the proposed changes.

Thanks

@AleLudovici
Copy link
Author

Hi @jflinter any chance you could have a look at this issue?
I've opened a PR #51 with the changes.

Let me know,
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant