Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digital cover arts sometimes not hidden #788

Open
jesus2099 opened this issue Sep 18, 2023 · 2 comments
Open

Digital cover arts sometimes not hidden #788

jesus2099 opened this issue Sep 18, 2023 · 2 comments

Comments

@jesus2099
Copy link
Owner

jesus2099 commented Sep 18, 2023

Probably depending on concurrent loading with FUNKEY CAA, digital cover arts are randomly not hidden.

Seen this on Sony Music Labels, where there are no cover arts on physical releases, only on digital releases.

On desktop, no problems: no cover arts, and the hide/show button works.
On mobile: they randomly appear, and if so, the hide/show button is ineffective on these cover arts.

My desktop and mobile list of userscripts is almost the same and those script are in the same order (HIDE DL is in the middle and FUNKEY CAA is at the end).

It's random, so it's not because of #644.

@jesus2099
Copy link
Owner Author

Oh same happens in Raspbian 10 with Chrommium.

  • Problem on Android 9 Kiwi and Raspbian 10 Chromium.
  • No problem on Windows 10 Vivaldi.

@jesus2099
Copy link
Owner Author

Ah it's because of this:

I should make it an interval that stops once found, a wait_for_element() or anything like that.

@jesus2099 jesus2099 pinned this issue Sep 30, 2023
@jesus2099 jesus2099 changed the title Sometimes cover arts not hidden Sometimes digital cover arts not hidden Sep 30, 2023
@jesus2099 jesus2099 changed the title Sometimes digital cover arts not hidden Digital cover arts sometimes not hidden Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant