Simple extension for lazygit integration in vscode

[tom-pollak]

https://marketplace.visualstudio.com/items?itemName=TomPollak.lazygit-vscode

• toggle window with cmd+shift+l
• runs "natively" as a tab in the main editor window, rather than in the integrated terminal bottom panel
• toggling hides and shows the tab, rather than quitting and restarting each time
• feedback is welcome!

[tom-pollak]

lazygit-vscode-demo.mp4

[stefanhaller]

This is quite nice, thanks!

One thing that I would wish for is that when I activate lazygit, it automatically hides the side bar and the bottom panel (as if pressing Command-B and Command-J if they are open), and ideally remembers the state and restores it again when you hide lazygit.

(Would you prefer feedback like this as an issue in your repo?)

[stefanhaller]

OK, here's a PR: tom-pollak/lazygit-vscode#1

It doesn't yet remember the visibility of the side bar and panel, I couldn't figure out how to do that. But I find this to be an improvement already.

[tom-pollak]

that was a problem in the previous version, but I thought I fixed it recently. I might of messed of publishing/versioning, so I've pushed a new 0.0.6 release that should definitely have the fixed changes. lmk if your still experiencing the bug

[HoT-1]

https://marketplace.visualstudio.com/items?itemName=ChaitanyaShahare.lazygit

[HoT-1]

The extension above does the same, has been in existence for some time, works well and already has some reach.
Maybe @tom-pollak would consider to join forces rather than starting a new extension.

P.S.: I'm not associated with the extension in any way.

[stefanhaller]

OK, thanks for the additional info. I have to disagree though, the extension only provides a small subset of the functionality that Tom's extension provides.

[tom-pollak]

I did try this extension, but IME (biased) it just boils down maximising the terminal bottom-panel and runs lazygit && exit. This also ran into problems for me when you had more than one terminal open.

As I use lazygit as my primary git ui, I wanted a more "native" window dedicated to lazygit, which you can toggle or just access as a tab or quick open. I don't think this is compatible with the above extension.

[tom-pollak]

If you give this extension a try lmk what you think. you can even click e or o from the files pane in lazygit to open the file as a tab in the vscode window. makes the experience quite clean.

[stefanhaller]

you can even click e or o from the files pane in lazygit to open the file as a tab in the vscode window

To be fair though, that doesn't have anything to do with your extension. Everybody running lazygit in a VS Code terminal gets that feature.

I was going to comment on that section in your README, btw, and then forgot: I recommend to use e, not o, because e can even jump to the correct line when you use it in the staging panel, and o can't. o was meant to be used to open files in the same way as when you double-click them in the Finder, so it's mainly meant for image files or things like that.

[stefanhaller]

@tom-pollak The recent update to 0.1.4 made things significantly worse for me:

• on every first use I get the error Uncaught error: lazygitpath is undefined!. Second time it works.
• The options to auto-hide side bar and panel are broken. They work when the lazygit is not running yet, but if it is, they no longer work.

Honestly I don't understand why you made all these changes. Caching the config and reloading it if it has changed is unnecessary; just query the individual configs every time you need them (like you did before), they always reflect the current setting, no need to cache and reload. I'd be curious to know what you were trying to improve with this.

[tom-pollak]

sorry about that! this was mainly so I could give a custom config (so I can use nvim on cli, vscode with the extension with e), and things started to get a bit messy. might of gone a little overboard though.

anyway I've undone the autohide changes, so auto-hide should be working, and the onetime undefined error should also be taken care of in v0.1.5

I think this extension should be pretty much complete (if these changes fix your issues) lmk if your still encountering the problems in 0.1.5

[stefanhaller]

this was mainly so I could give a custom config

But for that, reloading of the extension doesn't help if the config changed. You'll need to reload lazygit for changes to take effect; reloading the extension doesn't do that. I'd just leave that up to the user to quit lazygit and hit Command-Shift-L again when they change the custom config path.

[tom-pollak]

I refactored loading config settings out to loadConfig (rather than querying settings directly in createWindow).

then I went and added a small oldConfig === newConfig check when loading the new config because we don't need to reload if the configs the same (skips fs.existsSync, and I don't want to give "Custom config file not found at ${globalConfig.configPath}" warnings every time the window is opened, just on setting changes)

this shouldn't reload the whole extension? just the config each time window is created as you said

[stefanhaller]

Seems to work fine again, thanks for the quick fix! I still don't understand why you need the added complexity of caching and reloading the config, but that's your choice. 😄)

[tom-pollak]

no worries, I'll stop messing with it now 😁