Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roots deploy -to heroku doesn't deploy production files #676

Open
i8ramin opened this issue Sep 13, 2015 · 4 comments
Open

roots deploy -to heroku doesn't deploy production files #676

i8ramin opened this issue Sep 13, 2015 · 4 comments

Comments

@i8ramin
Copy link
Contributor

i8ramin commented Sep 13, 2015

Running roots deploy -to heroku doesn't seem to run the production env compilation before deploying.

Manually running roots compile -e production and then ship public/ -to heroku works as expected. Tried latest master branch of roots cli as well.

Easy to reproduce.

  • roots clean
  • roots deploy -to {any target}
  • inspect contents of public folder .. not production files
@benadamstyles
Copy link
Contributor

Pretty sure this is expected behaviour. The deploy command can't know what you have decided to call your production app.coffee file, I don't think it assumes it's called app.production.coffee. I could be wrong.

@i8ramin
Copy link
Contributor Author

i8ramin commented Sep 13, 2015

tried passing in a -e production to it as well, but no difference.

@benadamstyles
Copy link
Contributor

Oh I see. I'll have a look at the roots source, maybe this can be fixed in a quick pr. You can always write an npm script like roots compile -e production && ship public/ -to heroku. However, you might need to use my fork of roots here (the kill-compile branch) which quits the compile process, which otherwise just hangs.

@jescalan
Copy link
Owner

This seems like a valid issue to me. At least you should be able to pass the environment flag to the deploy command. If someone could take a crack at a PR for this, would be incredible. If not I will get to this eventually, but I'm afraid it might be a while as I'm pretty strapped for time at the moment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants