-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roots deploy -to heroku doesn't deploy production files #676
Comments
Pretty sure this is expected behaviour. The deploy command can't know what you have decided to call your production |
tried passing in a -e production to it as well, but no difference. |
Oh I see. I'll have a look at the roots source, maybe this can be fixed in a quick pr. You can always write an npm script like |
This seems like a valid issue to me. At least you should be able to pass the environment flag to the deploy command. If someone could take a crack at a PR for this, would be incredible. If not I will get to this eventually, but I'm afraid it might be a while as I'm pretty strapped for time at the moment! |
Running
roots deploy -to heroku
doesn't seem to run the production env compilation before deploying.Manually running
roots compile -e production
and thenship public/ -to heroku
works as expected. Tried latest master branch of roots cli as well.Easy to reproduce.
public
folder .. not production filesThe text was updated successfully, but these errors were encountered: