Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DependencyBundlingAnalyzer #630

Closed
jeremylong opened this issue Dec 13, 2016 · 2 comments
Closed

Fix DependencyBundlingAnalyzer #630

jeremylong opened this issue Dec 13, 2016 · 2 comments

Comments

@jeremylong
Copy link
Owner

The DependencyBundlingAnalyzer has grown over time from multiple PRs to do things it was not originally intended to do (at least not at the phase it is running in). Additionally, how the bundling analyzer works in conjunction with the suppression analyzer it is possible that vulnerabilities are being hidden (see issue #629). What needs to be done is the following:

  1. Split the bundling based on package path into a separate analyzer that runs prior to CPE identification. This will allow us to better solve issues like Reduce multiplicities in .NET scans #453. When doing this consider renaming package path to something more along the lines of coordinates as that seems to be more what we can "bundle" on. Note, this is solely for multiple file type analyzers that may each generate a dependency (based on different artifacts) for the exact same dependency. An example would be a dependency from analyzing NuSpec and another from analyzing the actual DLL - the goal would be to report only a single dependency with multiple sources of evidence.

  2. Solve for CVE suppressions with regards to the bundling related dependencies. The vulnerability analysis should run, then the suppression analysis, then finally the bundling and we should only bundle what appear to be related dependencies if the vulnerability count is the same (based off of identical CPE identifications, etc.).

jeremylong added a commit that referenced this issue Dec 22, 2016
jeremylong added a commit that referenced this issue Dec 22, 2016
jeremylong added a commit that referenced this issue Dec 22, 2016
jeremylong added a commit that referenced this issue Dec 22, 2016
@jeremylong
Copy link
Owner Author

This has been implemented in 1.4.5-SNAPSHOT and will be included in the next release. The new DependencyMergingAnalyzer will likely need additional re-work when we solve #453.

@lock
Copy link

lock bot commented Sep 28, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Sep 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant