-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support yarn berry in Analyzer #4894
Comments
Same issue here, running |
There is a task similar to this, #4215, but there is no solution implemented yet. It looks like, to resolve this we need to wait for a solution for the gradle plugin org.owasp.dependencycheck and till we have a solution we need to add the following setting to our build.gradle configuration : dependencyCheck { WARNING: This will disable yarn dependency check and if you are using yarn not for tests such as functional tests etc. your code may have vulnerabilities. There are some other dependency check plugins but they are not as good as this one. |
Hello, Any news on this ? |
Hi, Yarn Berry seems to not yet be supported 2025. |
It isn't high on our list of priorities because the results won't be different then just running |
Thanks for the response. Did I understand correctly that you are suggesting to not use DependencyCheck if we use an updated version of yarn? Yarn v1 Classic states that it is in maintenance mode in January 2020 and suggests users to migrate to Yarn berry. |
I think what he's suggesting is that ODC doesn't add much value with either yarn v1 or yarn v2+ because all it does is aggregate the issues reported via yarn into its own report, and allow for some sort of suppression tracking - but it doesn't discover anything new itself. It can be useful to some folks to consolidate via ODC's reporting when working in a multi-language project or to aggregate with retirejs, but that is not as valuable as other ODC capabilities which need love/energy (unless someone puts a whole lot of energy into a PR). Given this has been the state for nearly 3 years now, I suspect it's not of huge value to anyone? I briefly looked at what was going to be required to implement this, but after seeing the delta between how ODC works with yarn v1 and what would be needed for later yarns to work with |
I have created a separate Analyzer for Yarn Berry and it seems to work fine. This is a first draft and I would be happy to implement tests and make any other modifications if there is interest to merge this to main. The PR: #7319 |
Is your feature request related to a problem? Please describe.
Using
yarn berry
with workspaces doesn't work right now. Would be great to also support this updated version of yarn.Tried with the latest CLI version:
./dependency-check.sh --out . --scan ...
Repository to reproduce: https://github.com/Purii/yarn-monorepo-example
Result:
Describe the solution you'd like
There's already a comment in another thread: #4215 (comment)
These commands are not valid for latest versions of yarn anymore:
DependencyCheck/core/src/main/java/org/owasp/dependencycheck/analyzer/YarnAuditAnalyzer.java
Line 214 in aa73c25
Since yarn berry is very different to yarn classic, I suggest to treat it as a separate dependency manager instead of extending the existing yarn implementation.
The text was updated successfully, but these errors were encountered: