-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-44104] - Add optional support of downloading new Remoting versions from master #724
Comments
It can be done by pass docker-agent/debian/Dockerfile Line 101 in 8096ca3
Can we close this issue? |
@zhan9san I believe that the request is to download the new remoting version when the container is run rather than when the container is built. Doesn't the |
Hi @MarkEWaite Let me try to understand this case. User caseIf a image tag, I think the only way we can do it is to add some logic in entrypoint, Possible SolutionAdd an environment variable I'd like to hear your feedback. |
I think that your idea would work, though I'm not that we want to add this suggested enhancement in any case. Replacing the version of remoting inside the agent container seems worse (to me) that expecting that the user will configure the remoting / agent version explicitly. |
That is true, but in that case, the user should track the image tag version and is expected to update it to But let's consider you're using the However it should not enabled by default. It's really important otherwise the default behavior stopped to be deterministic. It would be a huge source of breakage, hard to reproduce or debug. Something like this could probably work:
WDYT? |
Totally agree with you. If the tag version is not the same as the one really using, it would introduce confusion.
it would introduce confusion also. I find the original request is for In my option, the remoting version should be set explicitly. Generally, if we upgrade jenkins controller, we have to test the compatibility firstly, whether the remoting works with both old and new version of controller before upgrade. |
I'm sorry I don't understand what you are asking for then. If you want the remoting version I might be missing something: can you elaborate on the root problem? |
The request is from #724 (comment) IIUC, the request expects to overwrite the remoting version in image to another one which is from Jenkins controller. I think we should reject it as well. |
Oh my bad, i understand now. I agree with you, the issue should be refused ! |
See https://issues.jenkins-ci.org/browse/JENKINS-44104
There was an attempt to do it in jenkinsci/docker-inbound-agent#19, but it was rejected. This update should be optional.
The text was updated successfully, but these errors were encountered: