-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code simplification: removal of default build ARG
values when factorized
#418
Labels
Comments
No objection to cleaning up the code |
No objection from me. Thanks for the idea! |
This was referenced May 18, 2023
5 tasks
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this issue
Nov 27, 2023
feat(Windows): add Java 21 and bump `jenkins/agent` parent images to `3148.v532a_7e715ee3-12`
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this issue
Jan 11, 2024
feat(Windows): add Java 21 and bump `jenkins/agent` parent images to `3148.v532a_7e715ee3-12`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While working on #417 and #409 , I wondered if we could not simplify the "spread" of build arg values to factorized locations (1 for all Linux and one for all Windows).
The goal is to avoid any leftover when updating a JDK, Git or any important component.
@team-docker-packaging I remember the constraint of having a value for build-arg in the
Dockerfile
because of the DockerHub automated builds (major) and allowing users to build a standaloneDockerfile
without the need for additional tools (minor).But today (May 2023):
docker
CLI client-side plugins easy to install for edge cases) even on Windows and LinuxAny objection for a code cleanup to remove, only when specified through a centralize file(s) , the values from
Dockerfile
?The text was updated successfully, but these errors were encountered: