Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code should match the lint rules of the parent Lens application #2

Open
haysclark opened this issue Nov 13, 2021 · 0 comments · May be fixed by #3
Open

Code should match the lint rules of the parent Lens application #2

haysclark opened this issue Nov 13, 2021 · 0 comments · May be fixed by #3

Comments

@haysclark
Copy link
Contributor

It would be good to establish some lint rules. As this is a plug-in it is often common to inherit the formatting and styles guides of the parent application.
haysclark added a commit to haysclark/jx-lens that referenced this issue Nov 13, 2021
@haysclark
style(eslint): matching style of lensapp
ff5348e 
- adds eslint rules from lensapp root project
- include-header rules have disabled
- performed `eslint —fix`
- surpressed the few eslint errors related to unused-imports/no-unused-vars-ts
- adds ‘lint’ steps to `test` script
- adds jest `--passWithNoTests` to `test` script
- resolves jenkins-x-plugins#2

Signed-off-by: Hays Clark <[email protected]>
@haysclark haysclark linked a pull request Nov 13, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style(eslint): matching style of lensapp haysclark/jx-lens
1 participant
@haysclark