Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hosting checker didn't fail when no GitHub user or Jenkins project users #4231

Closed
timja opened this issue Dec 16, 2024 · 4 comments · Fixed by #4233
Closed

Hosting checker didn't fail when no GitHub user or Jenkins project users #4231

timja opened this issue Dec 16, 2024 · 4 comments · Fixed by #4233
Labels
bug

Comments

@timja
Copy link
Member

timja commented Dec 16, 2024

Reproduction steps

see #4204

### Repository URL

https://github.com/Simplify3x/simplifyqa-pipeline-executor-plugin

### New Repository Name

simplifyqa-pipeline-executor-plugin

### Description

when i build the plugins with the parameters,it will execute the testcase and execute the pipelines in simplifyQA.

### GitHub users to have commit permission

### Jenkins project users to have release permission

### Issue tracker

GitHub issues

and #4204 (comment)

Expected Results

Ensured at least one of each specified

Actual Results

Passed and failed on the PR for hosting (developers list empty: c11532f)

Anything else?

No response
@timja timja added the bug label Dec 16, 2024
@Simplify3x
Copy link
Contributor

what is bug here

@timja
Copy link
Member Author

timja commented Dec 18, 2024

The hosting verifier wrongly marked hosting as successful when there was no users, which made parts of the process fail later that I had to manually fix

@Simplify3x

This comment was marked as off-topic.

Sign in to view
@Simplify3x

This comment was marked as off-topic.

Sign in to view
mawinter69 added a commit to mawinter69/repository-permissions-updater that referenced this issue Dec 20, 2024
@mawinter69
check that user lists contain at least 1 user
4d748e4 
fix jenkins-infra#4231

Check that there is at least one user declared for github and jenkins
project
@mawinter69 mawinter69 mentioned this issue Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

check that user lists contain at least 1 user mawinter69/repository-permissions-updater
2 participants
@timja @Simplify3x