Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indusface WAS CICD plugin publish #4187

Closed
productteam-was opened this issue Nov 22, 2024 · 96 comments
Closed

Indusface WAS CICD plugin publish #4187

productteam-was opened this issue Nov 22, 2024 · 96 comments
Labels
bot-check-complete Automated hosting checks passed hosting-request Request to host a component in jenkinsci security-audit-done The hosting request code passed the security audit with success

Comments

@productteam-was
Copy link
Contributor

productteam-was commented Nov 22, 2024

Repository URL

https://github.com/productteam-was/indusface-was-scan

New Repository Name

indusface-was-plugin

Description

  1. A DAST Scanner Plugin for Automated Security Testing: This plugin integrates seamlessly into the Jenkins Pipeline interface, allowing for automated security/DAST scanning within CI/CD workflows.
  2. Streamlined Security Integration: Incorporating security checks early in the development lifecycle, it helps identify vulnerabilities before they reach production, ensuring faster and safer releases.
  3. Enhanced CI/CD Security: Indusface WAS plugin enables early detection and mitigation of security vulnerabilities through automated DAST scans within the development process.
  • Automatically triggers security scans during the build process.
  • Retrieves and displays scan results.
  • Fails builds based on predefined security thresholds.
    -If your plugin provides a more user-friendly interface or simplified configuration process.

GitHub users to have commit permission

@productteam-was
@techieabhishekakash

Jenkins project users to have release permission

indusface_jenkins_plugin

Issue tracker

Jira

@productteam-was productteam-was added the hosting-request Request to host a component in jenkinsci label Nov 22, 2024
@jenkins-cert-app
Copy link
Collaborator

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command.

Security team only:

  • /audit-ok => the audit is complete, the hosting can continue 🎉.
  • /audit-skip => the audit is not necessary, the hosting can continue 🎉.
  • /audit-findings => the audit reveals some issues that require corrections ✏️.

Anyone:

  • /request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository 🔍.
  • /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings 👀. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.31.74)

@jenkins-cert-app jenkins-cert-app added the security-audit-todo The security team needs to audit the hosting request code label Nov 22, 2024
Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @indusface_jenkins_plugin (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @indusface_jenkins_plugin (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: The following usernames in 'GitHub Users to Authorize as Committers' are not valid GitHub usernames or are Organizations: AzureAD\GamyaSriyaSomalaraju
  • ⛔ Required: The dependency org.json:json should be replaced with a dependency to the api plugin io.jenkins.plugins:json-api
  • ⛔ Required: The dependency com.google.code.gson:gson should be replaced with a dependency to the api plugin io.jenkins.plugins:gson-api

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@jenkins-cert-app
Copy link
Collaborator

The Jenkins Security Scan discovered 2 finding(s) 🔍.

For every identified issue, please do one of the following:

  • Implement the recommended fix to address the issue.
  • If you think it's a false positive, suppress the warning directly within the code.
  • Alternative, you write an explanation here about why you think it's irrelevant. That will require a manual review, leading to a slower process.

After addressing the findings through one of the above methods:

  • If all modifications have been made to the code, please initiate a new security scan by triggering the /request-security-scan command.
  • If there are any unresolved findings (those not corrected or suppressed), request a review from the Jenkins security team by using the /audit-review command.

Jenkins: Plaintext password storage

You can find detailed information about this finding here.

SamplePostBuildAction.java#29
Field should be reviewed whether it stores a password and is serialized to disk: accessKey
ScanAndBuildStatus.java#7
Field should be reviewed whether it stores a password and is serialized to disk: secretKey

@jenkins-cert-app jenkins-cert-app added security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request and removed security-audit-todo The security team needs to audit the hosting request code labels Nov 22, 2024
@productteam-was
Copy link
Contributor Author

/hosting re-check

@productteam-was
Copy link
Contributor Author

/request-security-scan

@jenkins-cert-app jenkins-cert-app added security-audit-todo The security team needs to audit the hosting request code and removed security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request labels Nov 26, 2024
@jenkins-cert-app
Copy link
Collaborator

The Jenkins Security Scan discovered 2 finding(s) 🔍.

For every identified issue, please do one of the following:

  • Implement the recommended fix to address the issue.
  • If you think it's a false positive, suppress the warning directly within the code.
  • Alternative, you write an explanation here about why you think it's irrelevant. That will require a manual review, leading to a slower process.

After addressing the findings through one of the above methods:

  • If all modifications have been made to the code, please initiate a new security scan by triggering the /request-security-scan command.
  • If there are any unresolved findings (those not corrected or suppressed), request a review from the Jenkins security team by using the /audit-review command.

Jenkins: Plaintext password storage

You can find detailed information about this finding here.

SamplePostBuildAction.java#29
Field should be reviewed whether it stores a password and is serialized to disk: accessKey
ScanAndBuildStatus.java#7
Field should be reviewed whether it stores a password and is serialized to disk: secretKey

@jenkins-cert-app jenkins-cert-app added security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request and removed security-audit-todo The security team needs to audit the hosting request code labels Nov 26, 2024
@productteam-was
Copy link
Contributor Author

productteam-was commented Nov 26, 2024

/audit-review

I have changed the field type to text , so it is not required to store as a password

@jenkins-cert-app jenkins-cert-app added security-audit-correction-review The hosting request code was adjusted, a new security review must be done and removed security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request labels Nov 26, 2024
@Wadeck
Copy link
Collaborator

Wadeck commented Nov 27, 2024

/audit-findings

I have changed the field type to text , so it is not required to store as a password

The presence of that field in an object that is stored on disk is sufficient to have the confidential information stored in plain text. You have to use a Secret to store it securely.

@jenkins-cert-app jenkins-cert-app added security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request and removed security-audit-correction-review The hosting request code was adjusted, a new security review must be done labels Nov 27, 2024
@productteam-was
Copy link
Contributor Author

/request-security-scan

@jenkins-cert-app jenkins-cert-app added security-audit-todo The security team needs to audit the hosting request code and removed security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request labels Dec 1, 2024
@jenkins-cert-app
Copy link
Collaborator

The Jenkins Security Scan discovered 1 finding(s) 🔍.

For every identified issue, please do one of the following:

  • Implement the recommended fix to address the issue.
  • If you think it's a false positive, suppress the warning directly within the code.
  • Alternative, you write an explanation here about why you think it's irrelevant. That will require a manual review, leading to a slower process.

After addressing the findings through one of the above methods:

  • If all modifications have been made to the code, please initiate a new security scan by triggering the /request-security-scan command.
  • If there are any unresolved findings (those not corrected or suppressed), request a review from the Jenkins security team by using the /audit-review command.

Jenkins: Plaintext password storage

You can find detailed information about this finding here.

ScanAndBuildStatus.java#7
Field should be reviewed whether it stores a password and is serialized to disk: secretKey

@jenkins-cert-app jenkins-cert-app added security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request and removed security-audit-todo The security team needs to audit the hosting request code labels Dec 1, 2024
@productteam-was
Copy link
Contributor Author

/request-security-scan

@jenkins-cert-app jenkins-cert-app added security-audit-todo The security team needs to audit the hosting request code and removed security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request labels Dec 1, 2024
@productteam-was
Copy link
Contributor Author

I Missed it Thank you. I have removed the dependency.

@productteam-was
Copy link
Contributor Author

@mawinter69 I have updated pom .

@mawinter69
Copy link
Contributor

/hosting re-check

@mawinter69
Copy link
Contributor

/request-security-scan

@jenkins-cert-app jenkins-cert-app added security-audit-todo The security team needs to audit the hosting request code and removed security-audit-done The hosting request code passed the security audit with success labels Dec 23, 2024
Copy link

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

@jenkins-cert-app
Copy link
Collaborator

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉


💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

@jenkins-cert-app jenkins-cert-app added security-audit-done The hosting request code passed the security audit with success and removed security-audit-todo The security team needs to audit the hosting request code labels Dec 23, 2024
@mawinter69
Copy link
Contributor

/hosting host

@mawinter69
Copy link
Contributor

@productteam-was
Please consider setting up automated security scans as described in https://www.jenkins.io/redirect/jenkins-security-scan/

@jenkins-infra-bot
Copy link
Contributor

Hosting request complete, the code has been forked into the jenkinsci project on GitHub as https://github.com/jenkinsci/indusface-was-plugin

A Jira component named [indusface-was-plugin](https://issues.jenkins.io/issues/?jql=project+%3D+JENKINS+AND+component+%3D+ indusface-was-plugin)has also been created with indusface_jenkins_plugin as the default assignee for issues.

A pull request has been created against the repository permissions updater to setup release permissions. Additional users can be added by modifying the created file.

Please delete your original repository (if there are no other forks), under 'Danger Zone', so that the jenkinsci organization repository is the definitive source for the code. If there are other forks, please contact GitHub support to make the jenkinsci repo the root of the fork network (mention that Jenkins approval was given in support request 569994). Also, please make sure you properly follow the documentation on documenting your plugin so that your plugin is correctly documented.

You will also need to do the following in order to push changes and release your plugin:

Welcome aboard!

@productteam-was
Copy link
Contributor Author

Hosting request complete, the code has been forked into the jenkinsci project on GitHub as https://github.com/jenkinsci/indusface-was-plugin

A Jira component named [indusface-was-plugin](https://issues.jenkins.io/issues/?jql=project+%3D+JENKINS+AND+component+%3D+ indusface-was-plugin)has also been created with indusface_jenkins_plugin as the default assignee for issues.

A pull request has been created against the repository permissions updater to setup release permissions. Additional users can be added by modifying the created file.

Please delete your original repository (if there are no other forks), under 'Danger Zone', so that the jenkinsci organization repository is the definitive source for the code. If there are other forks, please contact GitHub support to make the jenkinsci repo the root of the fork network (mention that Jenkins approval was given in support request 569994). Also, please make sure you properly follow the documentation on documenting your plugin so that your plugin is correctly documented.

You will also need to do the following in order to push changes and release your plugin:

Welcome aboard!

Hi Team @jenkins-infra-bot Invitation link is Expired Can You Please Resend the invitation to the Jenkins CI Org on Github

@timja
Copy link
Member

timja commented Jan 7, 2025

resent

@productteam-was
Copy link
Contributor Author

productteam-was commented Jan 7, 2025

Hi Team @jenkins-infra-bot ,
As per the Plugin Release document provided, I am trying to enable the Continuous Delivery flag in the Repository Permission Updater (RPU) for our plugin. However, it appears that I do not have the necessary permissions to push the changes. Could you please provide me with access?

Details:

Username: productteam-was
Email: [email protected]
Thank you!

@productteam-was
Copy link
Contributor Author

Hi Team @jenkins-infra-bot , As per the Plugin Release document provided, I am trying to enable the Continuous Delivery flag in the Repository Permission Updater (RPU) for our plugin. However, it appears that I do not have the necessary permissions to push the changes. Could you please provide me with access?

Details:

Username: productteam-was Email: [email protected] Thank you!

Hi @timja Can you please help getting access to RPU

@mawinter69
Copy link
Contributor

mawinter69 commented Jan 7, 2025

You need to open a PR from your own fork of this repo. You can't push directly.

@productteam-was
Copy link
Contributor Author

You need to open a PR from your own fork of this repo. You can't push directly.

Thank you

@productteam-was
Copy link
Contributor Author

Hi Team,

I followed the steps provided to release the plugin. However, the release workflow did not automate as expected, and I had to execute Release manually. Could you please help me identify if I am missing something in the setup?

How long does it usually take for the plugin to become available in the Jenkins Marketplace after the release?

@mawinter69
Copy link
Contributor

For the CD to automatically jump in you need to give the pull request a label. Not all of the labels lead to a new release.
E.g. if you label it enhancement or bug, then once the PR is merged and the build on ci.jenkins.io was successful then a new release is automatically triggered. But labels like internal or documentation do not lead to a new release.
Labeling your pull request will also make the release drafter properly format the release.
After the CD action has run it takes up to 5 or 6 hours until it becomes visible on the plugin site of Jenkins, in the plugin manager of your instance it is visible much earlier

@productteam-was
Copy link
Contributor Author

enhancement
Okay I'll try to add label and Check.

when I search From Jenkins dashboard navigate to Manage Jenkins > Manage Plugins and select the Available tab. I'm not able to see the plugin

@mawinter69
Copy link
Contributor

Jenkins is caching the available plugins. You might want to refresh by clicking on the button in the upper right. I can see the plugin on my instance

@productteam-was
Copy link
Contributor Author

Hi @mawinter69 We are unable to see the plugin in our Jenkins instance, even after refreshing .

@mawinter69
Copy link
Contributor

Then potentially you're using a Jenkins version lower than 2.462.3 which you've chosen as minimum required Jenkins version for your plugin

@productteam-was
Copy link
Contributor Author

productteam-was commented Jan 17, 2025

Hi @mawinter69 Can we release the plugin the same way Creating PR if there are any code changes?

@mawinter69
Copy link
Contributor

mawinter69 commented Jan 17, 2025

For automatic releases you need a Pull Request. Give the PR a meaningful label and when merged the release happens automatically.
I can see you released a new version. https://github.com/jenkinsci/indusface-was-plugin/releases And I can already see this new version in my Jenkins instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-check-complete Automated hosting checks passed hosting-request Request to host a component in jenkinsci security-audit-done The hosting request code passed the security audit with success
Projects
None yet
Development

No branches or pull requests

8 participants