Media deletion label disambiguation

[hdavidkim]

Hello, I would like to take on this feature request as it seems pretty straightforward and would indeed be a good QoL improvement. I'll be checking if the item type is a series or episode and will change the string to indicate as such. Looking over how item types are defined, I may follow up with an increased scope feature so that each different item are clearly given a specific deletion label.

Am I correct in assuming that I should just come up with translation keys as needed and then go into the translator app to add in the entries for english with other languages soon following suit (by someone else since I don't know those languages)?

This will be my first code change for jellyfin so please give me whatever tips you feel are appropriate.

Thanks!

[hdavidkim]

also, am i correct in assuming that the docker file I use to spin up a test app is Dockerfile.docker or is that just for production deployment? I'm pretty new to docker so I'm a bit confused on how to launch and test the webapp using it

[dmitrylyzo]

There is a PR already.
#5232

[hdavidkim]

oh, that's great. added my thoughts on the PR there. Could we get the feature request marked as "started"?

also, am i able to approve that other PR or is it policy to wait for someone with more jellyfin dev experience to give a final review?

[nielsvanvelzen]

Pull requests in the web repository need at least 1 approval from a Jellyfin team member in the web team. Other contributors can help out, but it always needs 1 team member.