Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't add a less button after two times #42

Open
tobias-redmann opened this issue Oct 4, 2017 · 2 comments
Open

Doesn't add a less button after two times #42

tobias-redmann opened this issue Oct 4, 2017 · 2 comments

Comments

@tobias-redmann
Copy link

truncate.js/dist/truncate.js

Line 496 in f34e7e8

includeShowLess = false;

I tried to using the plugin but for some reason it don't add a less button after expand it two times (expand, collapse, expand). I found the reason at that line, but don't really know why this is happen.

Find my fiddle and try it by yourself: https://jsfiddle.net/tricd/ovw1mtz8/
@vangelis183
Copy link

hi @tobias-redmann
did you find a solution?

dekatron added a commit to dekatron/truncate.js that referenced this issue Jan 15, 2018
@dekatron
Fix dissapearing less button closes jeffchan#42
057d9c2 
The show less button dissapears after click show more for the second time. It looks like it was originally planned that there would be a seperate behaviour for explicit and implicit expand and collapse but I can't see that an implicit expand and collapse was ever implemented. As such all open and closes are explicit and the show less button shouldn't be removed unless we want to remove it (in which case it can be done manually in the appication logic)
@iljapanic
Copy link

Hi @tobias-redmann, did you end up finding a fix?
cc: @vangelis183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vangelis183 @iljapanic @tobias-redmann