-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Adding sound to slides #375
Comments
Hello @JohnyMarley! This is a long waited feature, see #258. The issue is that partial movie files, so the videos we use to cut a presentation into slides, do not contain audio. My plan is to first include audio in partial movie files generated by Manim, see ManimCommunity/manim#3347. Once merged, handling audio files would be pretty easy on the Manim Slides side. |
Awesome! is it possible for now to manually add the sound into the videos in postprocessing somehow? |
Not without changing Manim Slides' code a bit: manim-slides/manim_slides/present/player.py Lines 118 to 122 in 1dbd2fd
Here, I need to add some audio output. Then, if your files contain audio, they should be played normally. For HTML slides, the audio is already played, except for the first slide (because most browser do not allow playing audio automatically, so they will block your slide if the first video played contains audio). |
So if we need to add sound to the manim-slides, we should add these lines to the source code? After that, can we just use self.add("sound.wav") simply to add sound? Thx a lot! |
Hello @semikernel! As explained above, using |
* feat(present): add audio output This PR adds the necessary audio output to the presenter mode, so it can play audio contained in video files, see #375. However, this does not fix the issue that slides do not contain audio by default, but should be solved by Manim, see #375 for updates on that topic. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: PR number --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Hello,
It would be nice to be able to add sounds to slides. Is this a possibility?
Screenshots
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: