diff --git a/CHANGELOG.md b/CHANGELOG.md index 20a12b33..f299d819 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 (unreleased)= ## [Unreleased](https://github.com/jeertmans/manim-slides/compare/v5.4.1...HEAD) +(unreleased-fixed)= +### Fixed + +- Fixed `start_skip_animations` to actually pass argument to ManimCE, + otherwise video animations were still rendered, just excluded from + the final output. + [#524](https://github.com/jeertmans/manim-slides/pull/524) + (v5.4.1)= ## [v5.4.1](https://github.com/jeertmans/manim-slides/compare/v5.4.0...v5.4.1) diff --git a/manim_slides/slide/base.py b/manim_slides/slide/base.py index 64f23992..c648251a 100644 --- a/manim_slides/slide/base.py +++ b/manim_slides/slide/base.py @@ -594,9 +594,7 @@ def start_skip_animations(self) -> None: self._skip_animations = True def stop_skip_animations(self) -> None: - """ - Stop skipping animations. - """ + """Stop skipping animations.""" self._skip_animations = False def wipe( diff --git a/manim_slides/slide/manim.py b/manim_slides/slide/manim.py index 78d1ce0c..68842193 100644 --- a/manim_slides/slide/manim.py +++ b/manim_slides/slide/manim.py @@ -127,7 +127,10 @@ def next_slide( **kwargs: Any, ) -> None: Scene.next_section( - self, *args, skip_animations=base_slide_config.skip_animations, **kwargs + self, + *args, + skip_animations=base_slide_config.skip_animations | self._skip_animations, + **kwargs, ) BaseSlide.next_slide.__wrapped__( self, diff --git a/tests/test_base_slide.py b/tests/test_base_slide.py index 6ece844c..97cdee6a 100644 --- a/tests/test_base_slide.py +++ b/tests/test_base_slide.py @@ -87,13 +87,13 @@ def test_wait_time_between_slides(self, base_slide: BaseSlide) -> None: assert base_slide.wait_time_between_slides == 0.0 def test_skip_animations(self, base_slide: BaseSlide) -> None: - assert base_slide._skip_animations == False + assert not base_slide._skip_animations def test_start_and_stop_skip_animations(self, base_slide: BaseSlide) -> None: base_slide.start_skip_animations() - assert base_slide._skip_animations == True + assert base_slide._skip_animations base_slide.stop_skip_animations() - assert base_slide._skip_animations == False + assert not base_slide._skip_animations def test_play(self) -> None: pass # This method should be tested in test_slide.py diff --git a/uv.lock b/uv.lock index 52ead1bd..aaa6df30 100644 --- a/uv.lock +++ b/uv.lock @@ -1526,7 +1526,7 @@ wheels = [ [[package]] name = "manim-slides" -version = "5.4.0" +version = "5.4.1" source = { editable = "." } dependencies = [ { name = "av" },