Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Redirect URI incorrect when used with Express #83

Open
bradisbell opened this issue Jun 6, 2015 · 2 comments
Open

Redirect URI incorrect when used with Express #83

bradisbell opened this issue Jun 6, 2015 · 2 comments

Comments

@bradisbell
Copy link

I'm using Authom like this:

app.use('/auth/:service', authom.app);

I'm trying to authentication with Google, which uses OAuth2. The redirect_uri passed to Google contains / instead of /auth/google.

I think the problem is in oauth2.js where req.url is used:

this.code.query.redirect_uri = url.format(req.url)

If I add these two lines above this, the problem is resolved:

  req.url.pathname = req.baseUrl;
  delete req.url.href;

Similar changes still need to be made later on for onCode.

In any case, I think that originalUrl needs to come into play here because /auth/google isn't in req.url. Is this the correct fix? I would submit a pull request, but since this is an as-documented usage of Authom, I wanted to make sure I wasn't doing anything wrong to begin with. Any insight is welcomed! Thanks.

@bradisbell
Copy link
Author

I made some changes in a fork: bradisbell@894fc77 If that change looks good, I will put in a pull request. But, please let me know if this commit doesn't make any sense.

@JonNode28
Copy link

Is this going to be merged in? i'm still getting this issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants