src/packages/imagepreview/imagepreview.tsx (2)

121-141: 建议将魔法数字提取为常量

为了提高代码的可维护性，建议将以下值提取为命名常量：

• 双击时间阈值 (300ms)
• 缩放倍数 (2x, 3x)
• 缩放阈值 (1.1)

+const DOUBLE_TAP_THRESHOLD = 300; // ms
+const DEFAULT_SCALE = 1;
+const DOUBLE_TAP_SCALE = 2;
+const MAX_SCALE = 3;
+const MIN_SCALE_THRESHOLD = 1.1;

 const onTouchStart = (event: TouchEvent) => {
   const { touches } = event
   const events = touches[0]
   const events2 = touches[1]
   
   const curTouchTime = Date.now()
-  if (curTouchTime - lastTouchEndTime < 300) {
+  if (curTouchTime - lastTouchEndTime < DOUBLE_TAP_THRESHOLD) {
     const store1 = store
-    store1.scale = store1.scale === 1 ? 2 : 1
+    store1.scale = store1.scale === DEFAULT_SCALE ? DOUBLE_TAP_SCALE : DEFAULT_SCALE
     scaleNow()
   }

Also applies to: 145-164

---

266-287: 建议改进类型安全性

当前实现中的类型断言可以通过使用类型守卫（Type Guard）来改进：

+type MediaItem = {
+  type: 'video' | 'image';
+  data: VideoOption | ImageOption;
+};

+const isVideoOption = (item: MediaItem): item is { type: 'video', data: VideoOption } => {
+  return item.type === 'video';
+};

 {[
   ...videos.map((item) => ({ type: 'video', data: item })),
   ...images.map((item) => ({ type: 'image', data: item })),
 ]
   .sort((a, b) => (a.data.index ?? 0) - (b.data.index ?? 0))
   .map((item, index) => (
     <SwiperItem key={index}>
-      {item.type === 'video' ? (
+      {isVideoOption(item) ? (
         <Video
-          source={(item.data as VideoOption).source}
-          options={(item.data as VideoOption).options}
+          source={item.data.source}
+          options={item.data.options}
           onClick={closeOnImg}
         />
       ) : (
         <Image
-          src={(item.data as ImageOption).src}
+          src={item.data.src}
           draggable={false}
           onClick={closeOnImg}
         />
       )}
     </SwiperItem>
   ))}

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

src/packages/imagepreview/__test__/imagepreview.spec.tsx (1)

49-62: 很好的测试设置函数实现！

通过引入 setup 函数统一管理组件渲染，减少了代码重复，提高了测试代码的可维护性。

建议考虑以下优化：

 const setup = (props = {}) => {
-  render(
+  return render(
     <ImagePreview
       images={images}
       videos={videos}
       visible
       closeIcon
       defaultValue={0}
       onChange={mockOnChange}
       onClose={mockOnClose}
       {...props}
     />
   )
 }

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

src/packages/imagepreview/__test__/imagepreview.spec.tsx (2)

8-44: 建议将测试数据移至单独的文件

当前的测试数据（images和videos数组）直接定义在测试文件中，建议将其移至单独的测试数据文件中以提高可维护性和重用性。

+// src/packages/imagepreview/__test__/__fixtures__/testData.ts
+export const testImages = [
+  {
+    src: '//m.360buyimg.com/mobilecms/s750x366_jfs/t1/18629/34/3378/144318/5c263f64Ef0e2bff0/0d650e0aa2e852ee.jpg',
+  },
+  // ...
+]
+
+export const testVideos = [
+  {
+    source: {
+      src: 'https://storage.jd.com/about/big-final.mp4?Expires=3730193075&AccessKey=3LoYX1dQWa6ZXzQl&Signature=ViMFjz%2BOkBxS%2FY1rjtUVqbopbJI%3D',
+      type: 'video/mp4',
+    },
+    options: {
+      muted: true,
+      controls: true,
+    },
+  },
+  // ...
+]

---

49-62: 优化setup函数的类型定义

setup函数缺少类型定义，建议添加TypeScript类型以提高代码的可维护性。

-const setup = (props = {}) => {
+interface SetupProps extends Partial<ImagePreviewProps> {
+  // 添加测试特定的属性
+}
+
+const setup = (props: SetupProps = {}) => {
   render(
     <ImagePreview
       images={images}
       videos={videos}
       visible
       closeIcon
       defaultValue={0}
       onChange={mockOnChange}
       onClose={mockOnClose}
       {...props}
     />
   )
 }

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro