Skip to content
This repository has been archived by the owner on Aug 24, 2021. It is now read-only.

Replace (in code) number of iteration by min/max number of iterations #183

Open
jcornaz opened this issue Jul 27, 2020 · 0 comments
Open

Replace (in code) number of iteration by min/max number of iterations #183

jcornaz opened this issue Jul 27, 2020 · 0 comments
Labels
breaking There is no obvious way to introduce this change without breaking the API

Comments

@jcornaz
Copy link
Owner

jcornaz commented Jul 27, 2020

The actual number of iterations should always come from the global definition (in system properties or environment variables).

When we configure the iterations in code, it should be more a minimum or maximum.
So that the actual number of iteration is : defaultIterations.coerceIn(min, max).

Open questions

  • Does it makes sense to define both minimum and maximum, or should we allow to define only either?
@jcornaz jcornaz added the design label Jul 28, 2020
@jcornaz jcornaz added breaking There is no obvious way to introduce this change without breaking the API and removed design labels Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking There is no obvious way to introduce this change without breaking the API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcornaz