Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fix needed for setup.py for Windows environments. #253

Open
jeruyyap opened this issue Mar 1, 2022 · 1 comment
Open

Minor fix needed for setup.py for Windows environments. #253

jeruyyap opened this issue Mar 1, 2022 · 1 comment

Comments

@jeruyyap
Copy link

jeruyyap commented Mar 1, 2022

There is minor issue with this package in Windows environments that causes installation to fail due to the encoding not being specified for the README file in setup.

A quick fix that comes to mind for this would be to specify utf8 when opening the README in the setup.py:
with open('README.rst', encoding='utf8') as readme_file:

This seems to be an issue in 2.3.0 but not in 2.2.4.
@kangelovv
Copy link

I hit this as well, on Debian Buster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeruyyap @kangelovv