Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] dark mode for the whole site #106

Open
Just-some-one opened this issue May 30, 2024 · 3 comments
Open

[request] dark mode for the whole site #106

Just-some-one opened this issue May 30, 2024 · 3 comments

Comments

@Just-some-one
Copy link

i think it would be nice to have dark mode plus the current light mode
steering on the screen for long time is not comfortable in the light mode

@nasrob
Copy link

nasrob commented Jul 16, 2024

I agree that it would be a great addition to our current light mode. I'd like to work on this feature. However, I have a couple of questions:

  • Is there a specific theme or style guide we should follow for the dark mode design?
  • Are there any particular elements or sections of the app that you think would benefit most from a dark mode treatment?

@danthe1st
Copy link
Contributor

I'd like to work on this feature.

Note that the version on the website has some things (like a search) that aren't available in this repository so I don't know whether you could really contribute it as you couldn't properly test it with whatever they changed in the UI since then.

@carimura
Copy link
Member

Great idea. i don't think much has changed in terms of CSS. I could try and sync the two repos but this might not be necessary to get a dark mode theme working. As for theme or style guide, we do our best to follow the WCAG rules, one in particular for dark theme might be contrast ratio of 7 to 1 [1] [2].

[1] https://www.w3.org/WAI/WCAG22/quickref/?showtechniques=141%2C146#contrast-enhanced

[2] https://www.w3.org/WAI/WCAG22/Techniques/general/G17.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants