Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group membership synchronization #5

Open
sbernhard opened this issue Dec 18, 2020 · 5 comments · May be fixed by aeecleclair/PiwigoOpenIdConnect#3
Open

Group membership synchronization #5

sbernhard opened this issue Dec 18, 2020 · 5 comments · May be fixed by aeecleclair/PiwigoOpenIdConnect#3

Comments

@sbernhard
Copy link

As there are groups available in piwigo, there should be something like a group membership sync be done in the OpenId Connect plugin.

What this be possible?

@jasperweyne
Copy link
Owner

Unfortunately, the OpenID Connect protocol doesn't have a built-in solution to indicate group membership for users. An OIDC provider may choose to indicate group membership through one or more claims (see the OpenID Connect Core specification), but there is no universal standard for this. Therefore, a solution that would utilize custom claims would need to be highly flexible. Furthermore, since OIDC is a user-centered protocol, groups synchronization would be custom as well.

Given these shortcomings in the protocol, I'd argue a custom plugin for your specific problem would be preferable over integrating a solution in this plugin. However, I'd be happy to discuss any suggestions.

@sbernhard
Copy link
Author

@sbernhard
Copy link
Author

What is your thought about group membership association similar to the xwiki implementation?

@jasperweyne
Copy link
Owner

Hi, my apologies for the lack of response, I must have missed your messages. This might be a feasible solution, I'll investigate further as soon as possible. However, I also feel it's important to note that I don't have much time to develop new features for this plugin, so whether I'll be able to develop it myself will be dependent upon the complexity. I'll let you know how this pans out!

@ashemsay
Copy link

Hey, I made a pr (#13) regarding this and it's working fine with my keycloak configured to send the user's groups list in the oidc token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants