Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests should be optional #2

Open
Civil opened this issue Feb 22, 2015 · 8 comments
Open

Tests should be optional #2

Civil opened this issue Feb 22, 2015 · 8 comments

Comments

@Civil
Copy link

Civil commented Feb 22, 2015

Hi,

I'd like to make a package of tinyssh in Gentoo, but currently it's required a lot of patching to build system.

Tests should be optional - otherwise it'll break cross compilation. Also portage runs under unprivileged user, so one test will always fail. Also because of that it's now impossible to crosscompile tinyssh.

@grazzolini
Copy link

I don't know it this is related to the same issue you are facing, @Civil. But I have a similar issue that appeared on 20160301 that is affecting the build of tinyssh in some cases. I'm one of the maintainer of the tinyssh AUR package for Archlinux, and the build process fails on one test:

--- tinysshd.exp 2016-02-26 05:10:22.000000000 -0300
+++ tinysshd.out 2016-03-18 10:48:40.663333332 -0300
@@ -477,7 +477,7 @@

--- tinysshd 'logs kex problem' when client closed the connection

-unable to receive kex-message (connection reset)
+unable to send kex-message (broken pipe)

--- tinysshd 'logs kex problem' when client disconnected the connection

On previous versions I didn't had this issue. Also, it seems not to affect every system, but we had reports of some people not being able to build the package. And I reproduced this error using a qemu-kvm virtual machine.

@grazzolini
Copy link

And I just saw now that issue #13 fixed this problem. Sorry for the noise.

@Civil
Copy link
Author

Civil commented Mar 18, 2016

Well, my problems are related to the fact that gentoo builds packages inside a sandbox and some features are not allowed there, but tests are using them, so they obviously fails.

Currently there is no way to remove tests without hacking into build system which I don't actually want to do (cause it's too weird). So I'll wait until author will switch to something saner than bash scripts as a build system (e.x. autotools, cmake, etc).

@lilydjwg
Copy link

I have problems with the tests as well as I'm cross-compiling. tinyssh is well suited for tiny embedded systems, except that it's so unpleasant to cross-compile.

@janmojzis
Copy link
Owner

Hello,
can You prepaire separate Makefile, make* script or something like that to allow cross-compiling?

@janmojzis
Copy link
Owner

janmojzis commented Aug 26, 2016

I tried to add support for cross-compilation in the branch cc, script make-tinysshcc.sh

  • no test, no executing binaries

Can You please try it?

Thanks
Jan

@lilydjwg
Copy link

@janmojzis make-tinysshcc.sh works fine for me 👍

@janmojzis
Copy link
Owner

Switched to a simple Makefile here #91,
and test are optional now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants