Replies: 1 comment
-
I agree 👍🏻 I would need to bump the major version, though, since it would be a breaking change. I would first like to give the latest gem version a few weeks in the wild, in case someone reports an issue with the switch to the new |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Does it make sense to remove this from the gemspec and offer guidance instead (for example, how Sidekiq does https://github.com/sidekiq/sidekiq/blob/5054ee46fa6cea66d7acaea6e78112c895ea1a28/lib/sidekiq/transaction_aware_client.rb#L41-L45)?
I realize that in the case of Sidekiq, if you want the features provided by the after_commit_everywhere gem, it's because you are opting in to transaction aware client, whereas for sequel-activerecord_connection, it's required for core functionality. I'm just thinking for users on Rails 7.2+, it would be nice to not see this gem in the lock file, even though it's not being required or used at all.
Beta Was this translation helpful? Give feedback.
All reactions