Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyEntity and Identity items should not use kSecReturnData #9

Open
macblazer opened this issue Sep 12, 2024 · 0 comments
Open

KeyEntity and Identity items should not use kSecReturnData #9

macblazer opened this issue Sep 12, 2024 · 0 comments

Comments

@macblazer
Copy link
Contributor

According to Apple's documentation for returning keychain items:

"""
Don’t use kSecReturnData for cryptographic key or identity items, as the key material may not be extractable. Instead, call SecKeyCopyExternalRepresentation(::), and check the error parameter if it returns nil.
"""

Probably we can hide this implementation detail within Haversack when running a KeyQuery that has kSecReturnData in it.

Be sure to test with keys that are not extractable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant