Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3 update #3

Open
currymj opened this issue Jul 22, 2019 · 1 comment
Open

python3 update #3

currymj opened this issue Jul 22, 2019 · 1 comment

Comments

@currymj
Copy link
Contributor

currymj commented Jul 22, 2019

Python 2 is going to be completely EOL starting January 1, 2020. Fortunately this repository is quite clean and has few dependencies, so automatically running 2to3 on this code resulted in code where all tests run and pass under Python 3.

Let me know if there's any other tests I should try to avoid subtle bugs, and whether or not a pull request for the Python 3 update would be worth submitting.

@currymj
Copy link
Contributor Author

currymj commented Jul 22, 2019

One minor change is that the main script needs to be run as:

python -m kidney_solver.kidney_solver 3 3 picef < example_data/MD-00001-00000100.input

instead of calling it directly, due to changes in the Python 3 import system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant