Select proper Launcher in case of multiple Launchers

[marchof]

If additional launchers are configured EclEmma seems to delegate to a random one which leads to unexpected results. See forum posts: https://groups.google.com/forum/?fromgroups=#!topic/jacoco/JP244L-DzbU

[kossmoboleat]

Is this hard to fix? Where would you start when implementing a fix, if the maintainers don't have enough time to look at it?

[marchof]

@kossmoboleat I don't think so. If somebody has the chance to study the APIs contributions are welcome. I might find some time to pick this up the next weeks.

[kossmoboleat]

@marchof Hmm, I don't know anything about Eclipse plugins, but maybe the relevant class is ILaunchConfigurationDelegate?

In the two lines below the first delegate is always chosen, which sounds like the described behavior:

eclemma/com.mountainminds.eclemma.core/src/com/mountainminds/eclemma/core/launching/CoverageLauncher.java

Lines 71 to 72 in fb939e0

	return type.getDelegates(Collections.singleton(DELEGATELAUNCHMODE))[0]
	.getDelegate();

I guess a good first default would be the normal JDT launcher, if there are only two launchers instead of something more specific like a VisualVM launcher. You usually don't want to profile and measure coverage at the same time...

[marchof]

@kossmoboleat Yep, that looks reasonable. Now we need a strategy to select the "correct" launcher for all 9 launch types we currently support. So the task is to identify the correct launcher IDs

org.eclipse.debug.core.ILaunchDelegate.getId()

and add a new attribute for the CoverageLauncher.

[wiwie]

any news on a fix for this bug? I am encountering it as well and the only workaround right now is to uninstall the additional launchers.