Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database extension requirements #70

Open
peter279k opened this issue Jan 28, 2020 · 3 comments
Open

Database extension requirements #70

peter279k opened this issue Jan 28, 2020 · 3 comments

Comments

@peter279k
Copy link

As title, it seems that this package requires PDO extension.

And the PDO should have PDO database extensions.

For example, the MySQL is with PDO support and it should require pdo_mysql.

@izniburak, should we add some suggest block on composer.json?

@izniburak
Copy link
Owner

@peter279k I think this can be unnecessary. Because, someone who used that library may be using one of MySQL, PostgreSQL or SQLite databases. All extension should not be required for those databases. I had already added ext-pdo extension requirement in composer.json file. I think this is enough.
You think?

@peter279k
Copy link
Author

@izniburak, thanks for your reply.

I mean we can consider letting these possible extensions on suggest block.

And this can remind developers required extensions if they want to use one of database with PDO supports.

@izniburak
Copy link
Owner

Yes! This is make sense. We can add required extensions to suggest block.

peter279k added a commit to open-source-contributions/pdox that referenced this issue Jan 30, 2020
peter279k added a commit to open-source-contributions/pdox that referenced this issue Jan 30, 2020
peter279k added a commit to open-source-contributions/pdox that referenced this issue Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants