Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy lint to help with no_std support #24

Open
i509VCB opened this issue Aug 3, 2022 · 1 comment
Open

Clippy lint to help with no_std support #24

i509VCB opened this issue Aug 3, 2022 · 1 comment

Comments

@i509VCB
Copy link
Contributor

i509VCB commented Aug 3, 2022

I recently wrote a few lints for clippy that should help with CI testing given the couple of "fix no_std" pull requests I've seen: rust-lang/rust-clippy#9103

Although I don't think these are going to be stable until Rust 1.64

@iximeow
Copy link
Owner

iximeow commented Sep 23, 2022

1.64 is out! grats on landing the lints!

i don't think there've been any no-std pull requests, but some commits if that's what you're thinking? in that case it was kind of mislabeled - i expect the crate to build with no features, so "no_std" (in a minimal sense) is cargo build --no-default-features. that didn't work for mundane reason about the fmt feature, but all did at least get std/core right. even then, cargo build --no-default-features --features "fmt" did work, i believe.. that said, doc comments do reference std::fmt::* because (iirc?) those can't be made to build no-std even if i wanted...

either way i'm super down for std_instead_of_core as a lint! though i rarely run clippy myself. yaxpeax-x86 using alloc would almost certainly be a bug though 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants