Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pools broken #16

Open
CamxxCore opened this issue May 28, 2021 · 2 comments
Open

Pools broken #16

CamxxCore opened this issue May 28, 2021 · 2 comments
Assignees

Comments

@CamxxCore
Copy link
Collaborator

CamxxCore commented May 28, 2021

Commit 0259e6a likely breaks pools entirely, since the previous calls already add the offset. Displacement is at +0x0, RIP is at +0x4. Can't test this now, just browsing and caught my attention.

char * location = pedPoolPattern.count(1).get(0).get<char>(3);

@DKingAlpha DKingAlpha self-assigned this May 29, 2021
@DKingAlpha
Copy link
Collaborator

DKingAlpha commented May 29, 2021

thx for the review. reverted 0259e6a at ac94d35.

Some pools are working now. A few others are causing native functions throwing exceptions. I am working on that.

Guess there could be a stack check. Will try to migrate the caller to the game mem region.

EDIT: ScriptHookV has simple working pools. It's not the game detection, just our implementation broken.

@DKingAlpha
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants