Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirecting status logging message outputs #402

Open
tomtau opened this issue Nov 30, 2020 · 4 comments
Open

Redirecting status logging message outputs #402

tomtau opened this issue Nov 30, 2020 · 4 comments

Comments

@tomtau
Copy link

tomtau commented Nov 30, 2020

Not sure if duplicate of #344

with tracing, one can implement a subscriber that will receive the log events -- e.g. instead of using standard output, one can use "console.log" in WASM: https://crates.io/crates/tracing-wasm

It'll be good if this is possible with status_*!(..., ...) logging macros too.
Currently, the status messages seem to use the Terminal component and it seems external applications can't modify terminal streams: https://github.com/iqlusioninc/abscissa/blob/develop/core/src/terminal.rs#L14

@tony-iqlusion
Copy link
Member

In general this is an important concern: all of the current logging macros use the log facade, and this has never been updated.

I agree all of the logging macros need to be revisited and updated to support tracing.

@JRAndreassen
Copy link

JRAndreassen commented Dec 1, 2020

A logging facility like tokio tracing would be optimal.
From my perspective (Windows service) a local logging to file with rotation
controllable from the config file (location, rotation and format) would be great.

@tony-iqlusion
Copy link
Member

@JRAndreassen Abscissa's logging subsystem has been based on tracing since Abscissa v0.5 released a year ago.

However, the logging macros use tracing via its log facade.

@JRAndreassen
Copy link

@tony-iqlusion :
Awesome...
The control of the output via the config is key for my environment.
Thanks
JR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants