-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For more security spongycastle -> bouncycastle #7
Comments
I'd be very happy to, but using bouncycastle caused a build failure on Android which is why I switched it in 811148f If you can get a working |
@mcb30: It is not complete: |
Sorry, I wasn't clear. I had to change from bouncycastle to spongycastle in order to get it to build successfully for Android. If you'd like to submit a working PR to change it back, I will happily merge it. |
@mcb30: It is not secure, CVEs, ... Currently Bouncy Castle last version is 1.65 and Spongy Castle last version is 1.58. Since several years, a lot of projects have already moved from Spongy Castle to Bouncy Castle because the project is dead. You can see discussion "34" in https://github.com/rtyley/spongycastle/issues. |
@Neustradamus I have absolutely zero objections to switching back to bouncycastle. The problem is that the build fails if I do so. Please submit a PR that fixes the build problem. |
@mcb30: What is the error? |
@mcb30: What is your solution? |
For more security, can you change old spongycastle (based on old bouncycastle) to bouncycastle?
The text was updated successfully, but these errors were encountered: