Replies: 2 comments
-
Makes sense, should be a low impact change. Probably want to include a deprecation warning for node_data |
Beta Was this translation helpful? Give feedback.
0 replies
-
Implemented in b78ca80 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Now that we'll finally handle attributes of
allmost objects in netlab topology, we could get rid of group.node_data and just define node attributes within a group dictionary.The attributes would be validated using a combination of
[ group, node ]
attributes + providers (so we would know they're valid) and everything but group attributes would be copied into node data.As a transition path, the early group data structure validation would copy everything in
node_data
back into the group dictionary and popnode_data
dictionary. After a long while, we would makenode_data
attribute invalid.Thoughts @ssasso @jbemmel?
Beta Was this translation helpful? Give feedback.
All reactions