Crash on server with AE2 & Minechem

[MJRLegends]

I've already posted it on the AE2 issue tracker as im not sure who will be able to help.

See AppliedEnergistics/Applied-Energistics-2#2337

Also my minechem version is Minechem-1.7.10-5.0.5.406 and AE2 is appliedenergistics2-rv3-beta-6

[Rumaruka]

I check your problem, but I working for Minechem mc1.8.9

[MJRLegends]

@Rumaruka ok im not sure whos fault it is tbh

[MJRLegends]

Applied Energistics are blaming Minechem for this issue as they have explained the reason to why its crashing

[Rumaruka]

Ok , i watch =)

[MJRLegends]

@Rumaruka any news?

[MJRLegends]

@Rumaruka did you read the AE2 dev comment on the issue??

[MJRLegends]

@way2muchnoise any chance you could please take a look at this issue?

[way2muchnoise]

I would if I had the time @MJRLegends , sadly I don't have it right now.

[MJRLegends]

Ok any if the other devs around?

[way2muchnoise]

There is no one around maintaining Minechem atm, and certainly not the 1.7.10 version. At least as far as I know

[MJRLegends]

Ok can you make sure if anyone does become active then this issue will need to be fixed first as its a major issue

[MJRLegends]

@way2muchnoise If i manage to fix it myself and submit a pull request will you create a release build containing it?

[way2muchnoise]

Sure

[MJRLegends]

@way2muchnoise I found a way to stop it crashing, What do you think about making the changes i've made below and releasing a public version with them?

Changed code

	@Override
	public boolean isItemValidForSlot(int i, ItemStack itemstack) {
		if (this.manager != null && this.manager != this) {
			try{
				return ((ISidedInventory) this.getManager()).isItemValidForSlot(i, itemstack);
			}
			catch (Exception ex){
				return false;
			}
		}
		return false;
	}

	@Override
	public int[] getAccessibleSlotsFromSide(int var1) {
		if (this.manager != null && this.manager != this) {
			try{
				return ((ISidedInventory) this.getManager()).getAccessibleSlotsFromSide(var1);
			}
			catch (Exception ex){
				return new int[0];
			}
		}
		return new int[0];
	}

Current Code in mod

    @Override
    public boolean isItemValidForSlot(int i, ItemStack itemstack)
    {
        if (this.manager != null && this.manager != this)
        {
            return ((ISidedInventory) this.getManager()).isItemValidForSlot(i, itemstack);
        }
        return false;
    }

    @Override
    public int[] getAccessibleSlotsFromSide(int var1)
    {
        if (this.manager != null && this.manager != this)
        {
            return ((ISidedInventory) this.getManager()).getAccessibleSlotsFromSide(var1);
        }
        return new int[0];
    }

[kaneweaver]

@MJRLegends is there any way you could send me the updated mod file with this change, I havn't had eclipse or anything downloaded in a long time.

[Blue64]

@kaneweaver it would be pushed as a new release