Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API v1.1.0] MONGO_DB_SOURCE_URL should not be hard coded #3

Open
zaarheed opened this issue Apr 21, 2020 · 0 comments
Open

[API v1.1.0] MONGO_DB_SOURCE_URL should not be hard coded #3

zaarheed opened this issue Apr 21, 2020 · 0 comments

Comments

@zaarheed
Copy link

In v1.0.0 you left all your API keys in the source code. In this version you have hard-coded MONG_DB_SOURCE_URL. You shouldn't do this because people might not want reference to your database in their production app. You should make this an environment variable so we can configure it to our own 'source'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zaarheed