Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CSS Variables and Theming #13

Open
tylerkrupicka opened this issue Feb 16, 2021 · 0 comments
Open

Improve CSS Variables and Theming #13

tylerkrupicka opened this issue Feb 16, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@tylerkrupicka
Copy link
Contributor

Currently the CSS variables are un-scoped, and don't really follow a strict naming convention. We could really improve this part of the project with a few enhancements:

  • Add a scope. Maybe devtools-ds? This would stop really generic variable names like textColor from colliding with variables in the page. We could look at scopes for other packages for ideas.
  • Add variables to the docs. Once we have a scope we can make it available as a "theming" API for components. This is a bit of a can of worms since variable name changes are now breaking API changes.
  • Improve variable names. Just make sure they are consistent and make sense, since they'll become an API.

Open to thoughts and suggestions.

@tylerkrupicka tylerkrupicka added the enhancement New feature or request label Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant