Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filesystem Repo doesn't list modules in descending order of versions #583

Closed
isc-shuliu opened this issue Oct 15, 2024 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@isc-shuliu
Copy link
Collaborator

isc-shuliu commented Oct 15, 2024

%IPM.Repo.Filesystem.PackageService:ListModules() doesn't return the latest version of each module by default, which is different from %IPM.Repo.Remote.PackageService:ListModules().

This affects #582 and ongoing work of #586

We should enforce a protocol such that any subclass of %IPM.Repo.IPackageService implements the ListModules() method in a manner that returns the latest version first.

@isc-shuliu isc-shuliu added the bug Something isn't working label Oct 15, 2024
@isc-shuliu isc-shuliu self-assigned this Oct 15, 2024
@isc-shuliu
Copy link
Collaborator Author

isc-shuliu commented Oct 22, 2024

After a closer look, the problem is %IPM.Repo.Filesystem.PackageService:ListModules() returns each module-version pair as an individual row instead of aggregating all versions of module to a single row (as required by the ROWSPEC of %IPM.Utils.Module:GetModuleList)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants