Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PublicData.get_decimal_precisions fails for very small or large numerical values #442

Open
michael-t-alexander opened this issue Aug 23, 2024 · 1 comment

Comments

@michael-t-alexander
Copy link

If the mode of a float type column is <= 1e-5 or >= 1e16, this line in get_decimal_precisions fails as the string representation of the mode uses scientific notation and doesn't contain a decimal point:

maxp = len(str(modes[0]).split('.')[1]) # maxp stores the maximum precision of the modes

@fabiensatalia
Copy link

fabiensatalia commented Jan 23, 2025

I have encountered this issue as well. Unlike with other issues, it is not generally possible to fix it without modifying the training data in a way that changes its meaning. I do not see a good way to work around it, some datasets simply cannot be used with DiCE until this bug is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants