Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include ID of foreign asset not found when rejecting #521

Open
bvotteler opened this issue Dec 22, 2022 · 1 comment
Open

Include ID of foreign asset not found when rejecting #521

bvotteler opened this issue Dec 22, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers prio:low

Comments

@bvotteler
Copy link
Contributor

The rejection message in DefaultAssetRegistryAPI.getForeignAsset(...) should include the id.

interbtc-api/src/parachain/asset-registry.ts

Line 99 in d987b57

return Promise.reject(new Error("Foreign asset not found"));

@bvotteler bvotteler added enhancement New feature or request good first issue Good for newcomers prio:low labels Dec 22, 2022
@artsytechie
Copy link

artsytechie commented Feb 14, 2023 •
edited
Loading

Hello, so we would want the id to be in the error message. For example:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers prio:low
Projects
Backlog
Status: Todo ⏳
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bvotteler @artsytechie